Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev branch for v1.7 #531

Closed
wants to merge 6 commits into from
Closed

Dev branch for v1.7 #531

wants to merge 6 commits into from

Conversation

radbasa
Copy link
Contributor

@radbasa radbasa commented Jan 11, 2024

Changes

  • box universal import linter

  • add box_universal_import_linter to .lintr template

  • documentation

  • package housekeeping

  • removed some lint

  • namespace box_universal_import_linter

  • reordered Suggests

  • update e2etest app files to rhino-box styleguide

  • address comments/suggestions in PR

  • fixed version number issue. moved xml2 to imports

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d3662f) 17.73% compared to head (d1c9a7d) 20.85%.

❗ Current head d1c9a7d differs from pull request most recent head fea7b83. Consider uploading reports for the commit fea7b83 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
+ Coverage   17.73%   20.85%   +3.11%     
==========================================
  Files           9       10       +1     
  Lines         406      422      +16     
==========================================
+ Hits           72       88      +16     
  Misses        334      334              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* update rhino app template unit test

* update e2etest app files

* remove what looks like stylr styling
@radbasa radbasa changed the title [Placeholder] Dev branch v1.7 Dev branch for v1.7 Jan 26, 2024
radbasa and others added 2 commits January 26, 2024 12:26
* box universal import linter

* add box_universal_import_linter to .lintr template

* documentation

* package housekeeping

* removed some lint

* namespace box_universal_import_linter

* reordered Suggests

* update e2etest app files to rhino-box styleguide

* address comments/suggestions in PR

* fixed version number issue. moved xml2 to imports
@jakubnowicki jakubnowicki deleted the dev_next branch February 2, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants